| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rename withCheckOptions to insertedCheckClauses |
| Date: | 2015-09-28 20:34:34 |
| Message-ID: | 28370.1443472474@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Dean Rasheed (dean(dot)a(dot)rasheed(at)gmail(dot)com) wrote:
>> Also, these were added in 9.4, so introducing this many differences
>> between 9.4 and 9.5+ will make back-patching harder.
> That's certainly true, but we don't want current or future hackers to be
> confused either.
Yes. I do not think that we should stick with badly chosen names just
because of back-patching concerns. By that argument, we should never
fix any erroneous comments either.
Whether these particular names are improvements is, of course, a fit
subject for debate. I have to agree that I don't feel like we've quite
hit on le mot juste yet.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-28 22:02:50 | pgsql: Fix poor errno handling in libpq's version of our custom OpenSSL |
| Previous Message | Stephen Frost | 2015-09-28 19:48:53 | pgsql: Ensure a few policies remain for pg_upgrade |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-09-28 20:37:06 | Re: 9.5: Can't connect with PGSSLMODE=require on Windows |
| Previous Message | Asif Naeem | 2015-09-28 20:08:56 | Re: 9.5: Can't connect with PGSSLMODE=require on Windows |