Re: Win32 defines

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 defines
Date: 2003-04-03 14:47:42
Message-ID: 28318.1049381262@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> This adds some Win32 defines to cygwin defines --- this isn't all of
> them, but it is most.

You got at least some of these backwards, eg

> ! #ifndef __CYGWIN__

> ! #if defined(__CYGWIN__) || defined(WIN32)

Also, are you sure that it's really appropriate to handle the native
port like Cygwin in each of these cases? Maybe so, I didn't look...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2003-04-03 15:07:43 Re: Win32 path patch
Previous Message Tom Lane 2003-04-03 14:43:27 Re: system() patch for Win32