From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Win32 defines |
Date: | 2003-04-04 20:48:28 |
Message-ID: | 200304042048.h34KmTN00295@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > This adds some Win32 defines to cygwin defines --- this isn't all of
> > them, but it is most.
>
> You got at least some of these backwards, eg
>
> > ! #ifndef __CYGWIN__
>
> > ! #if defined(__CYGWIN__) || defined(WIN32)
Thanks. Fixed. I reviewed them all, but hacked at this one after
checking.
> Also, are you sure that it's really appropriate to handle the native
> port like Cygwin in each of these cases? Maybe so, I didn't look...
I am goiing to back off some of these until it is compiled on Win32 ---
I am not positive if some of these are cygwin-specific changes and which
are Win32 also.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2003-04-05 05:29:29 | Re: Win32 defines |
Previous Message | Bruce Momjian | 2003-04-04 20:39:21 | Re: system() patch for Win32 |