CreateFakeRelcacheEntry versus Hot Standby

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: CreateFakeRelcacheEntry versus Hot Standby
Date: 2010-02-09 18:37:10
Message-ID: 27207.1265740630@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I was rather surprised to find this code still present:

/*
* We set up the lockRelId in case anything tries to lock the dummy
* relation. Note that this is fairly bogus since relNode may be
* different from the relation's OID. It shouldn't really matter though,
* since we are presumably running by ourselves and can't have any lock
* conflicts ...
*/
rel->rd_lockInfo.lockRelId.dbId = rnode.dbNode;
rel->rd_lockInfo.lockRelId.relId = rnode.relNode;

Seems quite unsafe in HS.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-02-09 19:06:36 Why doesn't smgr_redo truncate the VM fork too?
Previous Message Pavel Stehule 2010-02-09 18:08:49 Re: bugfix - VIP: variadic function ignore strict flag