Re: minor auth code cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: minor auth code cleanup
Date: 2002-08-27 15:15:39
Message-ID: 27027.1030461339@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
>> There may be existing clients out there that miscompute the password
>> packet length. Right now that does no harm. With an Assert in place
>> in the backend, it will cause a database system restart.

> Good point. However, I still think a sanity check would be appropriate
> here. How about an elog(WARNING) ?

I think that elog(LOG) is probably the right thing. IIRC, at that point
in startup we will not send anything short of ERROR to the client, so
elog(WARNING) is pointless from the client's point of view --- and a LOG
is actually more likely to get into the server's log than a WARNING.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 15:15:46 Re: minor auth code cleanup
Previous Message Bruce Momjian 2002-08-27 14:52:27 Re: minor auth code cleanup