Re: jdbc ResultSetMetaData::isWritable()

From: Rene Pijlman <rene(at)lab(dot)applinet(dot)nl>
To: ian(at)labfire(dot)com
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: jdbc ResultSetMetaData::isWritable()
Date: 2001-09-06 18:00:16
Message-ID: 26efptc7irkgohu63n7echr7593pv0mdot@4ax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:
>public boolean isWritable(int column) throws SQLException
>{
> if (isReadOnly(column))
> return true;
> else
> return false;
>}

The author probably intended:

public boolean isWritable(int column) throws SQLException
{
return !isReadOnly(column);
}

And if he would have coded it this way he wouldn't have made
this mistake :-)

>hence, isWritable() will always return false. this is something
>of a problem :)

Why exactly? In a way, true is just as incorrect as false, and
perhaps it should throw "not implemented". But I guess that
would be too non-backwardly-compatible.

>let me know if i can provide further information.

Will you submit a patch?

Regards,
René Pijlman <rene(at)lab(dot)applinet(dot)nl>

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Bruce Momjian 2001-09-06 18:26:49 Re: jdbc ResultSetMetaData::isWritable()
Previous Message Liam Stewart 2001-09-06 17:45:30 Re: driver source code indentation