Re: error report on slru.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gaetano Mendola <mendola(at)bigfoot(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: error report on slru.c
Date: 2004-10-02 23:23:44
Message-ID: 26994.1096759424@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gaetano Mendola <mendola(at)bigfoot(dot)com> writes:
> here a patch that
> 1) Rise the information about the file missing on pg_clog from
> detail to error

This violates the message style guidelines, IMHO.

> 2) Insert the offset information also for a missing file

It's hardly necessary, since the transaction number tells you everything
you need to know if you really need it, and the offset is certainly not
relevant to a file-open failure.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-02 23:27:39 Re: LDFLAGS overriding
Previous Message Reini Urban 2004-10-02 11:04:15 Re: LDFLAGS overriding