Re: array support patch phase 1 patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: array support patch phase 1 patch
Date: 2003-06-01 16:08:05
Message-ID: 26991.1054483685@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
>> A bigger problem is that I doubt this will actually work. Most of the
>> places that call compatible_oper will then proceed to call the function
>> from specialized code that does not bother with consing up an expression
>> tree --- so a polymorphic function is going to fail anyway...

> Well, not necessarily in the case of array_type-to-ANYARRAY. In that
> case the element type information in the array itself gives the function
> all the context it needs (if it looks there, which in the case of
> array_eq at least it does). Maybe it makes sense to only allow the
> array_type-to-ANYARRAY case?

Yeah, I think we could get away with that. It might be appropriate to
put that single special case into IsBinaryCoercible, instead of allowing
it only for the compatible_oper case. I can't recall offhand what else
uses IsBinaryCoercible ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-06-01 16:13:14 Re: array support patch phase 1 patch
Previous Message Joe Conway 2003-06-01 16:04:36 Re: array support patch phase 1 patch