Re: Bug #925: typing error in src/backend/libpq/be-secure.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: syatskevich(at)n21lab(dot)gosniias(dot)msk(dot)ru, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Bug #925: typing error in src/backend/libpq/be-secure.c
Date: 2003-03-29 04:23:37
Message-ID: 26886.1048911817@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Yep, typo. Patched to CVS current and backpatched to 7.3.X.

I think this fix is exactly backward. Why would SSL_write need to
return ERROR_WANT_WRITE? It couldn't. The correct fix is that
SSL_write might return ERROR_WANT_READ, for which reading would be
the right response.

BTW the real problem, both here and elsewhere in this file, is the
lack of a "default: elog-out" case in the switch statements. This
code will simply break if any unexpected case occurs.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2003-03-29 05:02:24 Re: Bug #925: typing error in src/backend/libpq/be-secure.c
Previous Message Bruce Momjian 2003-03-29 03:56:59 Re: Bug #925: typing error in src/backend/libpq/be-secure.c