Re: Order of pg_stat_activity timestamp columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Order of pg_stat_activity timestamp columns
Date: 2010-03-17 21:47:49
Message-ID: 26706.1268862469@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The current column ordering can be rationalized to some extent as
>>
>> 1. identity info (user id, db id, application name)
>> 2. current query info
>> 3. session info (backend start time, client addr/port)

> OK. I guess that trumps my idea, although it would sure be nice if
> it were possible to swap 2 and 3 so that we could put the query text
> at the end.

Well, the current ordering is definitely historical rather than
designed, but I'm hesitant to do more than minor tweaking. Even if we
think/hope it won't break applications, people are probably used to
seeing a particular ordering.

I'm not necessarily dead set against it though. I guess if we were
to do what you suggest, we'd end up with

identity:
datid | oid |
datname | name |
procpid | integer |
usesysid | oid |
usename | name |
application_name | text |
session:
client_addr | inet |
client_port | integer |
backend_start | timestamp with time zone |
transaction:
xact_start | timestamp with time zone |
query:
query_start | timestamp with time zone |
waiting | boolean |
current_query | text |

or possibly that plus relocate procpid somewhere else. Anyone think
this is sufficiently better to justify possible confusion?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2010-03-17 23:03:21 Re: Order of pg_stat_activity timestamp columns
Previous Message Kevin Grittner 2010-03-17 21:39:34 Re: Order of pg_stat_activity timestamp columns