Re: BUG #16345: ts_headline does not find phrase matches correctly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #16345: ts_headline does not find phrase matches correctly
Date: 2020-04-09 19:29:49
Message-ID: 26695.1586460589@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> I am getting a compiler warning, both with and without --enable-cassert.

> wparser_def.c: In function 'prsd_headline':
> wparser_def.c:2530:2: warning: 'pose' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> mark_fragment(prs, highlightall, bestb, beste);
> ^
> wparser_def.c:2384:6: note: 'pose' was declared here
> int pose,

I see it too, now that I try a different compiler version. Will fix.

> It makes no sense to me that pose could be used uninitialized on a line
> that doesn't use pose at all, so maybe it is a compiler bug or something.

It looks like the compiler is doing aggressive inlining, which might
have something to do with the crummy error report placement. Notice
that this isn't inside 'prsd_headline' at all, so far as the source code
is concerned.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2020-04-09 21:53:42 BUG #16354: No geos 3.8.1 package for RHEL 8
Previous Message Jeff Janes 2020-04-09 18:39:41 Re: BUG #16345: ts_headline does not find phrase matches correctly

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-04-09 19:57:00 Re: where should I stick that backup?
Previous Message Robert Haas 2020-04-09 19:29:09 Re: Parallel copy