Re: Collation patch's handling of wcstombs/mbstowcs is sheerest fantasy

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Collation patch's handling of wcstombs/mbstowcs is sheerest fantasy
Date: 2011-04-23 15:37:49
Message-ID: 26536.1303573069@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> * Where they're not, install the locale_t with uselocale(), do
> mbstowcs or wcstombs, and revert to the former locale_t setting.
> This is ugly as sin, and not thread-safe, but of course lots of
> the backend is not thread-safe.

I've been corrected on that: uselocale() *is* thread safe, at least in
glibc (it only affects the locale used by the current thread). And it's
"only a few instructions" according to Jakub Jelinek. So a temporary
setting via uselocale is exactly what you're supposed to do for any
locale-sensitive function that hasn't got a *_l variant.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-04-23 15:52:27 Re: What Index Access Method Functions are really needed?
Previous Message Dimitri Fontaine 2011-04-23 15:10:39 Re: pgbench \for or similar loop