Re: Fix oversight in pts_error_callback()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix oversight in pts_error_callback()
Date: 2005-08-10 15:25:02
Message-ID: 26391.1123687502@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes
>> Please exhibit a case in which you feel this is needed.

> Suppose I want to print a debug info in parseTypeString() like this:
> + elog(DEBUG1, "parse type %s", buf.data);
> raw_parsetree_list = raw_parser(buf.data);

That's a contrived example (and if I believed it, I would think that the
right answer is to emit no errcontext if the elevel is less than ERROR).
Give me an actual use case in which the patch gives a better rather than
worse error report. I think for most people it would just obfuscate the
message.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-08-10 15:29:49 Re: COPY FROM performance improvements
Previous Message Alvaro Herrera 2005-08-10 15:17:40 Re: 5 new entries for FAQ