Re: src/tools/msvc usage instructions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "Jeremy Drake" <pgsql(at)jdrake(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: src/tools/msvc usage instructions
Date: 2006-10-03 15:51:12
Message-ID: 26281.1159890672@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> which looks like they figured out that they needed to check
>> for MicroSoft C explicitly. I have no idea why they do not
>> define __STDC__ however.

> Can we just define __STDC__ when compiling that file (or rather, when
> compiling any bison-generated output file)? Or is that likely to cause
> *other* issues?

That seems pretty risky. Better to use the /Za switch or whatever it
was to get the compiler to assert it for itself. We have precedent for
adding yes-we'd-like-a-standard-compiler-please switches where
necessary, for instance adding -Ae to CFLAGS for HP's compiler.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-10-03 16:13:46 Re: timestamptz alias
Previous Message Tom Lane 2006-10-03 15:48:22 Re: src/backend/parser/parse_expr.c:exprTypmod() question