From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Hans-Jürgen Schönig <postgres(at)cybertec(dot)at>, Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>, Oliver Jowett <oliver(at)opencloud(dot)com>, Kris Jurka <books(at)ejurka(dot)com>, eg(at)cybertec(dot)at, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Implementing RESET CONNECTION ... |
Date: | 2005-01-07 15:36:50 |
Message-ID: | 26204.1105112210@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Hans-Jrgen Schnig wrote:
>> I completely agree with Karel. I think it is a bad idea to change the
>> protocol for such a minor feature - i tend to call it overkill.
> I think autocommit is a good example for comparison.
Indeed, it is an *excellent* example for comparison. The real problem
with autocommit was that it changed the interface semantics without
making that change sufficiently visible at all levels.
If we try to pretend that RESET CONNECTION isn't a protocol change
then we will silently break code that needs to know about it. Which is
pretty much exactly what happened with autocommit.
> Should we add something like SET
> CONNECTION that would set the reset values for RESET CONNECTION?
This is an even bigger compatibility-breaker, as now anyone who can
issue SET CONNECTION can not only break code layers that were trying to
track backend state, he can break code layers that thought they knew
what RESET CONNECTION would accomplish. I definitely recommend against
this idea.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-01-07 16:01:27 | Re: PostgreSQL 8.0.0 Release Scheduale |
Previous Message | Tom Lane | 2005-01-07 15:30:44 | Re: [HACKERS] Bgwriter behavior |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-01-07 16:25:14 | Re: pg_config MSVC makefile |
Previous Message | Dave Page | 2005-01-07 15:31:13 | Re: pg_config MSVC makefile |