| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assertion failure in get_attstatsslot() |
| Date: | 2010-07-09 23:08:09 |
| Message-ID: | 2570.1278716889@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Tom Lane's message of vie jul 09 12:16:42 -0400 2010:
>> If anybody feels really uncomfortable with that, we could add a
>> compensating "Assert(IsBinaryCoercible(ARR_ELEMTYPE(statarray),
>> atttype))" into get_attstatsslot(). Not sure if it's worth the cycles.
> Cycles spent only in assert-enabled builds? Why not?
I decided not to do it, not so much because of any performance worries
as that I didn't want to make lsyscache.c depend on the parser. Maybe
sometime we should rethink where the parse_coerce.c functionality lives.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2010-07-09 23:45:05 | Re: Assertion failure in get_attstatsslot() |
| Previous Message | Alvaro Herrera | 2010-07-09 22:49:27 | Re: Assertion failure in get_attstatsslot() |