Re: [PATCHES] Function to do runtime relative directory

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Function to do runtime relative directory
Date: 2004-05-05 13:55:35
Message-ID: 25459.1083765335@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Andrew Dunstan wrote:
>> Shouldn't this be
>> if (toupper(*src) != toupper(*dst))

> Yep, fixed.

Also, all of the ctype.h calls need to be like

toupper((unsigned char) *src)

to avoid problems with high-bit-set characters.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rod Taylor 2004-05-05 14:24:54 Re: PostgreSQL pre-fork speedup
Previous Message Alvaro Herrera 2004-05-05 12:20:11 Re: Multiple Xids in PGPROC?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tony Reina 2004-05-06 08:22:45 Re: Function to do runtime relative directory mapping
Previous Message Magnus Hagander 2004-05-04 20:13:17 Re: man pages on win32

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-05 14:42:56 Re: Dollar Quoting doc patch--resend.
Previous Message Neil Conway 2004-05-05 07:30:14 Re: Dollar Quoting doc patch--resend.