| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Christian Ullrich <chris(at)chrullrich(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-04-24 16:36:31 |
| Message-ID: | 25445.1461515791@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 04/24/2016 11:58 AM, Tom Lane wrote:
>> Hmm ... does this pragma work on *every* compiler we're going to use
>> on Windows?
> According to my research it works on all the MSVC versions we support. I
> didn't research the others (i.e. gcc), but we already use the pragma in
> float.c without ill effect. Isn't the way #pragma works that compilers
> that don't understand the particular pragma are just supposed to ignore it?
Well, the ones in float.c are guarded by "#if (_MSC_VER >= 1800)" and
will therefore not get compiled by any non-MSVC compiler. I don't see
any entirely-unprotected #pragma uses in our tree, indicating that
we've not depended on any such assumption up to now.
Given that the whole file is platform-specific, it may well be fine;
I'm just voicing some concern. I suppose the buildfarm will soon
tell us if it's not fine, though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2016-04-24 16:38:36 | Re: VS 2015 support in src/tools/msvc |
| Previous Message | Simon Riggs | 2016-04-24 16:30:35 | Re: Proposed change to make cancellations safe |