Are we done with sync-commit-defaults-to-off patch?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Are we done with sync-commit-defaults-to-off patch?
Date: 2007-09-09 16:28:14
Message-ID: 25259.1189355294@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When I was playing with pgbench testing yesterday, one thing that seemed
a bit odd was that turning off synchronous_commit didn't change the
results noticeably. It took till today for the reason to penetrate
my cranium: it was off already.
http://archives.postgresql.org/pgsql-hackers/2007-08/msg00355.php
http://archives.postgresql.org/pgsql-committers/2007-08/msg00182.php

We've had that hack in there for almost a month now, and no strange
behaviors have turned up in the buildfarm. So I'm inclined to think
it has served its purpose, and we should revert it before anyone else
comes to bogus conclusions about performance. This is particularly
the case since Andrew has worked up a pg_regress enhancement that would
let specific buildfarm animals still test the "off" setting if they
chose.

Comments?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2007-09-09 16:34:47 Re: ispell dictionary broken in CVS HEAD ?
Previous Message Tom Lane 2007-09-09 16:14:00 Re: invalidly encoded strings