| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Chernow <ac(at)esilo(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Subject: | Re: [PATCHES] libpq events patch (with sgml docs) |
| Date: | 2008-09-19 20:08:11 |
| Message-ID: | 25135.1221854891@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Chernow <ac(at)esilo(dot)com> writes:
> I attached a patch. You have to copy the events in PQmakeEmptyPGResult
> because there is no where else to do this, other than copyresult but
> that is different because it copies from a result not a conn.
Applied ...
> PQgetResult now calls PQfireResultCreateEvents.
... except I didn't do that because the error handling didn't seem
appropriate. Since PQmakeEmptyPGResult allows a null conn,
PQfireResultCreateEvents ought to as well. So I just made it return
false on failure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-19 20:14:16 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Joshua Drake | 2008-09-19 20:03:45 | Re: PostgreSQL future ideas |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-19 20:14:16 | Re: [PATCHES] libpq events patch (with sgml docs) |
| Previous Message | Tom Lane | 2008-09-19 19:54:39 | Re: [PATCHES] libpq events patch (with sgml docs) |