From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Bruce Momjian <bruce(at)momjian(dot)us>
Cc:
Andres Freund <andres(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>,
Andrew Dunstan <andrew(at)dunslane(dot)net>,
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: pg_upgrade problem with invalid indexes
Date:
2012-12-07 16:46:51
Message-ID:
25107.1354898811@sss.pgh.pa.us (view raw or flat )
Thread:
2012-12-07 00:28:33 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 00:31:46 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-12-07 00:58:03 from Jeff Davis <pgsql(at)j-davis(dot)com>
2012-12-07 01:05:56 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-12-07 01:37:28 from Jeff Davis <pgsql(at)j-davis(dot)com>
2012-12-07 00:35:19 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-12-07 00:38:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 00:53:57 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 01:16:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 02:10:21 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 02:23:14 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 02:41:00 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-12-07 02:45:11 from Stephen Frost <sfrost(at)snowman(dot)net>
2012-12-07 03:06:13 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 03:08:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 03:35:40 from Stephen Frost <sfrost(at)snowman(dot)net>
2012-12-07 03:27:48 from Stephen Frost <sfrost(at)snowman(dot)net>
2012-12-07 03:07:02 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 03:27:21 from Stephen Frost <sfrost(at)snowman(dot)net>
2012-12-07 14:21:58 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 14:24:46 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 14:27:39 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 14:32:51 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 14:44:18 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 15:29:22 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 16:08:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 16:46:51 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 16:57:34 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 19:24:49 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 03:06:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 04:02:26 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-12-07 09:16:56 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2012-12-07 14:23:09 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 13:58:04 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 14:12:36 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-12-07 18:22:12 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-12-07 18:27:08 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 18:44:53 from Josh Berkus <josh(at)agliodbs(dot)com>
2012-12-07 18:49:14 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 18:54:44 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 19:07:18 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 18:57:35 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 18:59:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 19:10:04 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 21:21:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 21:30:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-07 21:37:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-12-07 21:38:39 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-07 21:49:19 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-11 20:12:37 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-11 20:19:34 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-12-11 20:24:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-14 18:41:21 from Bruce Momjian <bruce(at)momjian(dot)us>
Lists:
pgsql-hackers
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Fri, Dec 7, 2012 at 10:29:22AM -0500, Tom Lane wrote:
>> On balance I am coming around to support the "just throw an error if
>> there are any invalid indexes" position. Adding extra complication in
>> pg_dump and pg_upgrade to handle ignoring them doesn't seem like a good
>> idea --- for one thing, it will evidently weaken the strength of the
>> same-number-of-relations cross-check.
> The check would remain the same --- the change would be to prevent
> invalid indexes from being considered on both the old and new servers.
But that weakens the check. For instance, if you had seven invalid
indexes in one cluster and eight in the other, you wouldn't notice.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2012-12-07 16:57:34Subject : Re: pg_upgrade problem with invalid indexesPrevious :From : Robert HaasDate : 2012-12-07 16:41:03Subject : Re: ALTER TABLE ... NOREWRITE option
