From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_upgrade problem with invalid indexes |
Date: | 2012-12-07 16:57:34 |
Message-ID: | 20121207165734.GJ31540@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 7, 2012 at 11:46:51AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Fri, Dec 7, 2012 at 10:29:22AM -0500, Tom Lane wrote:
> >> On balance I am coming around to support the "just throw an error if
> >> there are any invalid indexes" position. Adding extra complication in
> >> pg_dump and pg_upgrade to handle ignoring them doesn't seem like a good
> >> idea --- for one thing, it will evidently weaken the strength of the
> >> same-number-of-relations cross-check.
>
> > The check would remain the same --- the change would be to prevent
> > invalid indexes from being considered on both the old and new servers.
>
> But that weakens the check. For instance, if you had seven invalid
> indexes in one cluster and eight in the other, you wouldn't notice.
That is true, though the assumption is that invalid indexes are
insignficant. It would be a new case where actual non-system-table
_files_ were not transfered.
Seems most people want the error so I will start working on a patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-12-07 17:01:52 | Re: Support for REINDEX CONCURRENTLY |
Previous Message | Tom Lane | 2012-12-07 16:46:51 | Re: pg_upgrade problem with invalid indexes |