Re: EmitWarningsOnPlaceholders is too quiet

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: EmitWarningsOnPlaceholders is too quiet
Date: 2009-01-05 19:31:46
Message-ID: 24874.1231183906@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> (I'm actually kind of wondering what the INFO elog level is good for,
>> as this is just about the only use and it seems wrong.)

> +1 for one less logging level.

I rememebered what INFO is for: it's the elevel that VACUUM VERBOSE
uses to ensure that its output gets seen at the client. (I missed
that in my first grep because vacuum's elog/ereport calls don't use
INFO as a hard-wired elevel.) So we probably can't get rid of it.
But that makes it even more clear IMHO that EmitWarningsOnPlaceholders
shouldn't be using it. It's not intended for error/warning types of
uses, but for verbose logging.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-01-05 19:55:28 Re: QuickLZ compression algorithm (Re: Inclusion in the PostgreSQL backend for toasting rows)
Previous Message Tom Lane 2009-01-05 19:27:50 Re: Updates of SE-PostgreSQL 8.4devel patches (r1386)