Re: win32 pg_autovacuum make error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: win32 pg_autovacuum make error
Date: 2004-10-16 22:22:57
Message-ID: 2471.1097965377@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Matthew T. O'Connor" <matthew(at)zeut(dot)net> writes:
> Tom Lane wrote:
>> I have a better idea: make pg_autovacuum not use DLLists. That code
>> is slated for eventual removal from libpq anyway (if not complete
>> destruction). Had I been aware that autovacuum was using it I would
>> have objected ...
>>
> Ok, what do you recommend I replace the DLLists with?

I reconsidered --- seeing that autovacuum will eventually be server-side
code, it's not unreasonable for it to use DLList. It's just that it
shouldn't rely on libpq to provide DLList. I've committed a fix
already.

I think I'm going to go ahead and remove dllist.c from libpq, though.
The library will be smaller, faster, and more robust without it, and
8.0 seems like a good time to break anyone who is foolish enough to
be depending on it being in libpq ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-16 22:41:05 Re: Nearing final release?
Previous Message Matthew T. O'Connor 2004-10-16 21:55:49 Re: win32 pg_autovacuum make error