From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com> |
Cc: | Affan Salman <affan(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Deferred RI trigger for non-key UPDATEs and subxacts |
Date: | 2007-07-17 15:52:31 |
Message-ID: | 24389.1184687551@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com> writes:
> On Sun, 15 Jul 2007, Tom Lane wrote:
>> I don't think this is right. If the original tuple was inserted by a
>> subtransaction of our transaction, it will have been checked at
>> subtransaction subcommit, no?
> I don't think the subtransaction subcommit will do the check. Unless I'm
> missing something about the code, a CommitTransaction would but a
> CommitSubTransaction won't, which actually makes sense given that we're
> mapping savepoints on to it, and I don't think we are allowed to check at
> savepoint release time.
OK, that's what I get for opining before checking the code ;-). It
seems a little weird that a subcommitted subtransaction could still
cause a failure later, but that is how we're doing the triggers.
Given that, the proposed patch seems appropriate. Will apply.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-07-17 15:52:59 | Re: WIP: rewrite numeric division |
Previous Message | Tom Lane | 2007-07-17 15:21:05 | Re: WIP: rewrite numeric division |