| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Jason Erickson" <jerickso(at)indian(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #1545: LIBPQ Windows Version not calling WSACleanup for |
| Date: | 2005-05-05 16:23:22 |
| Message-ID: | 24368.1115310202@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> Actually ... why do we need a WSAStartup in makeEmptyPGconn?
>> If we have one in DLL attach, isn't that sufficient?
> Not if you link libpq as a static lib...
> I *think* that's why it was added. In the beginning it was only in the
> DLL attach code, and if you were using the library as a static lib you
> had to call it yourself. Not sure when that changed, but clearly that is
> when the WSACleanup() call should've gone in.
Ah. Makes sense. So adding it to freePGconn is correct.
Bruce, you should probably back-patch for as far as the WSAStartup call
is there, which looks to be 7.4.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-05-05 16:26:42 | Re: BUG #1545: LIBPQ Windows Version not calling WSACleanup for |
| Previous Message | Magnus Hagander | 2005-05-05 16:17:33 | Re: BUG #1545: LIBPQ Windows Version not calling WSACleanup for |