Re: Reducing some DDL Locks to ShareLock

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reducing some DDL Locks to ShareLock
Date: 2008-11-18 20:04:36
Message-ID: 24343.1227038676@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> heap_inplace_fetch takes as input "tuple" which is a palloc'd tuple,
> extracts from it the tid of the tuple, reads the buffer, locks it, then
> releases the original tuple. It then returns a copy of the on-block
> tuple. So all other code the same as before when we were working on a
> copy produced from the syscache.

> Is that roughly what you intended?

I'd suggest making it take a TID rather than presuming where the caller
is going to get the TID from. Otherwise, +1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-11-18 20:46:11 Re: Transactions and temp tables
Previous Message Simon Riggs 2008-11-18 19:50:54 Re: Reducing some DDL Locks to ShareLock