Re: [PATCH] Recreate Missing WAL Directories (from TODO)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
Cc: "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Recreate Missing WAL Directories (from TODO)
Date: 2008-11-08 21:08:58
Message-ID: 23860.1226178538@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Jonah H. Harris" <jonah(dot)harris(at)gmail(dot)com> writes:
> When performing a PITR copy of a data cluster, the pg_xlog directory
> is generally omitted. As such, when starting the copy up for
> replay/recovery, the WAL directories need to be recreated. This patch
> checks to see whether XLOGDIR and XLOGDIR/archive_status exist on
> XLOGStartup and if not, recreates them.

This has been suggested before but I'm unconvinced that it's a good
idea. It's reasonably common for pg_xlog to be a symlink. If you
neglect to re-establish the symlink then what would happen is that xlog
gets recreated on the data disk, and with no notice you are running in
a degraded mode.

It might be reasonable to auto-recreate XLOGDIR/archive_status, though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2008-11-08 22:12:58 Re: [PATCH] Recreate Missing WAL Directories (from TODO)
Previous Message Tom Lane 2008-11-08 21:03:32 Re: Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle