From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Tomonari Katsumata <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp>, pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: disabling log_rotation_age feature. |
Date: | 2014-06-12 14:41:35 |
Message-ID: | 23802.1402584095@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> On Thu, Jun 12, 2014 at 1:43 PM, Tomonari Katsumata
> <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp> wrote:
>> The document tells us to set it to ZERO if we want to disable the feature.
>> However, the feature would be disabled if we set it less than one minute.
> That's because log_rotation_age expects the setting value in minutes.
> This is not a problem only for log_rotation_age. When setting the parameter
> which expects the value in seconds to less than one second, the setting value
> is implicitly reset to the default.
It's not "reset to default", it's set to zero due to rounding the fraction
down. Some GUCs interpret zero specially, some don't.
I wonder if we should round fractions up instead of down in that logic?
It might be less surprising for those GUCs where zero is special, and
it seems like about a wash for most others.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David Johnston | 2014-06-12 15:32:49 | Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? |
Previous Message | Fujii Masao | 2014-06-12 12:26:09 | Re: disabling log_rotation_age feature. |