Re: Updates of SE-PostgreSQL 8.4devel patches (r1389)

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Oh, the patch also removes a bunch of "continue" statements that, as far
> as I can tell, no longer work after the macros were wrapped in
> do { ... } while (0) :-( I don't see any nice way to put the facility
> back.

Hmm ... I guess you could make the wrapping be "if (...) { ... } else {}"
instead of do/while, but I'm pretty dubious of having a continue in the
macros anyway --- that's an even stronger assumption about the context
the macro is being used in than the original gripe.

What you seem to be supposing is that the only possible use pattern
for these macros is a for-loop containing nothing but calls to one
or another of the macros. If so, shouldn't you be wrapping things
up at an even higher level? Maybe turn the whole thing into
table-driven code?

regards, tom lane