From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Björn Metzdorf <bm(at)turtle-entertainment(dot)de> |
Cc: | pgsql-general(at)postgresql(dot)org |
Subject: | Re: tsearch consistency trigger on inheritated table |
Date: | 2002-11-13 17:50:18 |
Message-ID: | 23681.1037209818@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general |
=?Windows-1252?Q?Bj=F6rn_Metzdorf?= <bm(at)turtle-entertainment(dot)de> writes:
> --- txtidx.c-orig Wed Nov 13 17:15:57 2002
> +++ txtidx.c Wed Nov 13 17:33:15 2002
> @@ -554,7 +554,7 @@
> numattr =3D SPI_fnumber(rel->rd_att, trigger->tgargs[i]);
> oidtype =3D SPI_gettypeid(rel->rd_att, numattr);
> - if (numattr < 0 || (!(oidtype =3D=3D TEXTOID || oidtype =3D=
> =3D VARCHAROID)))
> + if (numattr < 0 || (!(oidtype =3D=3D TEXTOID || oidtype =3D=
> =3D VARCHAROID || oidtype =3D=3D BPCHAROID)))
> {
> elog(NOTICE, "TSearch: can not find field '%s'", tr=
> igger->tgargs[i]);
> continue;
It would probably be better to have two different error messages for
the "field not found" and "field not right type" cases.
BTW, "character(100)" screams "lots of wasted space" to me. Why aren't
you using varchar, anyway?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Aurangzeb M. Agha | 2002-11-13 17:56:59 | Re: error: lost syncronization with server |
Previous Message | scott.marlowe | 2002-11-13 17:49:19 | Re: index question.. |