| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: standalone backend PANICs during recovery |
| Date: | 2016-08-30 12:48:22 |
| Message-ID: | 23650.1472561302@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Wed, Aug 24, 2016 at 5:07 PM, Bernd Helmle <mailings(at)oopsware(dot)de> wrote:
>> That said, i'm okay if --single is not intended to bring up a hot standby.
>> There are many other ways to debug such problems.
> This patch is still on the CF app:
> https://commitfest.postgresql.org/10/610/
> Even after thinking about it, my opinion is still the same. Let's
> prevent a standalone backend to start if it sees recovery.conf.
> Attached is a patch and the CF entry is switched as ready for
> committer to move on.
Hm, StartupXLOG seems like a pretty random place to check that, especially
since doing it there requires an extra stat() call. Why didn't you just
make readRecoveryCommandFile() error out?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2016-08-30 13:02:38 | Aggregate Push Down - Performing aggregation on foreign server |
| Previous Message | Peter Eisentraut | 2016-08-30 12:46:48 | sequences and pg_upgrade |