Re: WIN1252 encoding - backend or not?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "PostgreSQL Developers" <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: WIN1252 encoding - backend or not?
Date: 2004-12-04 17:59:58
Message-ID: 23488.1102183198@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> But further down we have:
> #define PG_ENCODING_BE_LAST PG_WIN1250

Scarier than that is grepping the source code for -i win125, and noting
the number of places that cover the existing WIN125[016] encodings but
fail to mention WIN1252. In particular I notice that pg_wchar_table[]
in wchar.c has no entry added for WIN1252, which means that this patch
broke every encoding with higher code numbers.

Bruce, I think this patch has to come out. We should not be in the
business of debugging a new feature post-RC1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-12-04 18:26:45 Re: WIN1252 encoding - backend or not?
Previous Message Tom Lane 2004-12-04 17:47:54 Re: WIN1252 encoding - backend or not?