Re: [HACKERS] Followup on the UnixWare Optimizer bug.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Followup on the UnixWare Optimizer bug.
Date: 2005-08-25 02:39:27
Message-ID: 23284.1124937567@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Good catch on the memory leak. I have applied the following fix.

These explicit pfrees are a waste of time, and probably actually
counterproductive as far as speed goes, because these functions
will always be invoked in relatively short-lived memory contexts.

I wouldn't object except that they seem to make the code noticeably
more obscure.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kris Jurka 2005-08-25 02:54:01 Re: TODO list comments
Previous Message Tom Lane 2005-08-25 02:18:38 Re: [HACKERS] Proposed patch to getaddrinfo.c to support

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-08-25 03:53:37 Re: [HACKERS] Followup on the UnixWare Optimizer bug.
Previous Message Tom Lane 2005-08-25 02:18:38 Re: [HACKERS] Proposed patch to getaddrinfo.c to support