Re: GiST: memory allocation, cleanup

Neil Conway <neilc(at)samurai(dot)com> writes:
> Tom Lane wrote:
>> I'm a bit dubious about this, mainly because you did not likewise
>> const-ify the other input arguments; it seems confusing to do a partial
>> const-ification.

> Well, "partial const-ification" is the rule rather than the exception in
> the backend right now. I'll take a look at adding more const qualifiers,
> but I don't really see why "partial const-ification" is confusing.

In this particular case I think it's confusing because the Datum and
nulls arrays are really two halves of a single data structure.
Const-ifying just one of them obscures that fact. I'd be happy if you
marked both of them const.

regards, tom lane