| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] postgres_fdw extension support |
| Date: | 2015-11-03 19:57:56 |
| Message-ID: | 23074.1446580676@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Paul Ramsey <pramsey(at)cleverelephant(dot)ca> writes:
> [ 20151006b_postgres_fdw_extensions.patch ]
Starting to look through this now. I'm dubious of the decision to have
ExtractExtensionList throw errors if there are un-installed extensions
mentioned in the FDW options. Wouldn't it be a lot more convenient if
such extension names were silently ignored? You cannot guarantee that the
list is always up to date anyway; consider creating a server, setting some
extension options, and then dropping some of those extensions. Moreover,
the current semantics create a hazard for pg_dump, which can't reasonably
be expected to know that it must restore extensions X and Y before it can
create foreign server Z.
There might be a case for raising a WARNING during
postgres_fdw_validator(), but no more than that, IMO. Certainly ERROR
during regular use of the server is right out.
Comments?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-11-03 20:02:42 | Re: [PATCH] postgres_fdw extension support |
| Previous Message | Robert Haas | 2015-11-03 19:24:18 | Re: Minor clarifying changes to abbreviated key abort code comments |