Skip site navigation (1) Skip section navigation (2)

Proposed cleanup of libpq's use of stderr

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org, pgsql-interfaces(at)postgreSQL(dot)org
Subject: Proposed cleanup of libpq's use of stderr
Date: 1998-07-26 21:19:34
Message-ID: 22936.901487974@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-interfaces
I've been thinking about changing the libpq library to reduce and
centralize its dependence on printing messages to stderr.  This
seems like a good idea on general principles, and it will be vital
if people want to run PostgreSQL clients on WIN32 (as Magnus Hagander's
recent patches make possible).  On a lot of WIN32 C compilers, output
to stderr goes into the bit-bucket, or causes the app to crash, or
even prevents it from being built in the first place.

There are two separate issues to address.  One is the handling of
NOTICE messages from the backend (such as EXPLAIN outputs).  libpq
is hardwired to dump these onto stderr.  I'm evidently not the first
person to be dissatisfied with that --- fe-exec.c contains

	/*
	 * Should we really be doing this?	These notices
	 * are not important enough for us to presume to
	 * put them on stderr.	Maybe the caller should
	 * decide whether to put them on stderr or not.
	 * BJH 96.12.27
	 */
	fprintf(stderr, "%s", conn->errorMessage);

What I propose we do is invent a callback hook that the application
can set to obtain control when a notice is received.  The default
hook function will just print the message to stderr as before, but
applications can override the default to do something else.  I suggest
a hook function signature like this

	void noticeProcessor (void * arg, const char * message)

and a new libpq accessor function

	void PQsetNoticeProcessor (PGconn * conn,
		void (*noticeProcessor) (void * arg, const char * message),
		void * arg)

The "arg" pointer is saved by PQsetNoticeProcessor and subsequently
passed to the notice processor.  This gives a way for the notice
processor to get to any application-dependent state associated with
the connection.

The other issue is that libpq has various internal error messages
that it willy-nilly prints on stderr, rather than handing back to the
application via the PQerrorMessage interface.  Some of these can
probably be eliminated or converted into PQerrorMessage returns.
If any remain after a cleanup pass, I'm inclined to invent an
"errorProcessor" hook just like the noticeProcessor hook described
above, so that the application can control what happens to the messages.

Does anyone have any objections or better ideas?  None of this will
affect the frontend/backend protocol, it'll just make libpq more
adaptable to frontend environments where writing to stderr isn't a
friendly thing to do.

			regards, tom lane

pgsql-hackers by date

Next:From: t-ishiiDate: 1998-07-27 01:35:09
Subject: Re: [HACKERS] current snapshot
Previous:From: Maarten BoekholdDate: 1998-07-26 19:43:17
Subject: Re: [HACKERS] Minor bug: inconsistent handling of overlength names

pgsql-interfaces by date

Next:From: Mohd RasyidiDate: 1998-07-27 03:16:04
Subject: Perl for postgersql
Previous:From: Julien MichielsenDate: 1998-07-26 17:14:42
Subject: setup of postgres user-interface

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group