Re: [PATCHES] Fix for large file support (nonsegment mode support)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Zeugswetter Andreas OSB SD <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Fix for large file support (nonsegment mode support)
Date: 2008-03-11 16:20:57
Message-ID: 22898.1205252457@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Tom Lane napsal(a):
>> These examples suggest that maybe what we want is not so much a "no
>> segments ever" mode as a segment size larger than 1GB.

> PS: ZFS is happy with 2^64bit size and UFS has 1TB file size limit
> (depends on solaris version)

So even on Solaris, "no segments ever" is actually a pretty awful idea.
As it stands, the code would fail on tables > 1TB.

I'm thinking we need to reconsider this patch. Rather than disabling
segmentation altogether, we should see it as allowing use of segments
larger than 1GB. I suggest that we ought to just flat rip out the "non
segmenting" code paths in md.c, and instead look into what segment sizes
are appropriate on different platforms.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-03-11 16:28:32 Re: [PATCHES] Fix for large file support (nonsegment mode support)
Previous Message Tom Lane 2008-03-11 16:11:13 Re: Autovacuum vs statement_timeout

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-03-11 16:28:32 Re: [PATCHES] Fix for large file support (nonsegment mode support)
Previous Message Zdenek Kotala 2008-03-11 16:07:30 Re: [PATCHES] Fix for large file support (nonsegment mode support)