From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
Cc: | Kenneth Marshall <ktm(at)rice(dot)edu>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [RRR] Tests citext casts |
Date: | 2008-11-07 19:50:04 |
Message-ID: | 22638.1226087404@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-rrreviewers |
"David E. Wheeler" <david(at)kineticode(dot)com> writes:
> Huh. There must be something different about the collation for en_US
> on Fedora than there is for darwin (what I'm using), because for me,
> as I said, all tests pass.
Yeah, Darwin seems to just use ASCII sort order in en_US (couldn't say
about its other locales). glibc-based systems definitely don't though.
>> We could fix it by having multiple variant expected files for C and
>> non-C locales, which is exactly what the core tests do. However,
>> I'm loath to apply that approach when the citext test already has
>> XML vs no-XML variants; we would then need two variant files per locale
>> variant, which is a bit unreasonable from a maintenance standpoint.
> This is why I like TAP.
And how would TAP reduce the number of expected results?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2008-11-07 19:58:57 | Re: [RRR] Tests citext casts |
Previous Message | David E. Wheeler | 2008-11-07 19:46:06 | Re: [RRR] Tests citext casts |
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2008-11-07 19:58:57 | Re: [RRR] Tests citext casts |
Previous Message | David E. Wheeler | 2008-11-07 19:46:06 | Re: [RRR] Tests citext casts |