Re: Last gasp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Smith <greg(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Last gasp
Date: 2012-04-11 14:24:20
Message-ID: 22532.1334154260@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Smith <greg(at)2ndQuadrant(dot)com> writes:
> On 04/10/2012 09:14 PM, Robert Haas wrote:
>> I wouldn't object to creating some doc-only committers. OTOH, I would
>> object to anyone making non-trivial documentation enhancements without
>> posting their patches first and having a second person look it over,
>> so how much difference is there, really?

> ...
> I'd like to dump around 50 pages of new material into the docs as a
> start, but I don't want to take so much time away from the code oriented
> committers to chew on that much.

Well, with all due respect, that does not sound like a change that
doesn't need review.

I have not noticed people adding docs-only changes to the CFs; usually
it's more like "post a patch, somebody looks it over and commits it".
I agree that this is still too much overhead for simple fixes, such
as the editorial glitches that Thom Brown is so good at finding
(and I'm about ready to vote to give him a commit bit for that work).
But a fifty-page chunk is not that, indeed it sounds like it would have
enough technical content that it might actually merit a full-scale
review.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2012-04-11 14:28:54 Re: Last gasp
Previous Message ktm@rice.edu 2012-04-11 13:02:44 Re: Patch: add timing of buffer I/O requests