Re: timezone GUC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: timezone GUC
Date: 2011-05-19 16:12:01
Message-ID: 22115.1305821521@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> So I think you whacked this around some more to get a *somewhat* more
> sensible behavior, but ISTM that the behavior here still not really
> right. Should we select a timezone at startup time even if we don't
> immediately need it, so that this can work correctly if we revert to
> the default down the road?

We could do that, but the issue that this code is trying to avoid is
that identify_system_timezone can easily add several seconds to the
postmaster startup time. So one of the reasons why someone would be
putting a timezone setting into postgresql.conf in the first place is
to not pay that startup overhead. I'm not thrilled with the idea
of defeating that in order to cover the corner case where they remove
the setting later.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-05-19 16:12:25 Re: patch: fix race in SSI's CheckTargetForConflictsIn
Previous Message Greg Stark 2011-05-19 16:11:29 Patch by request at pgcon