From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
Date: | 2016-10-24 21:59:53 |
Message-ID: | 2195.1477346393@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> An alternative that would be worth considering is to adopt a uniform
>> rule of // for line-ending comments and /* for all other uses.
> Why not. As far as comments are concerned, editors usually highlight them
> in some color, and my eyes get used to the comment color, so the simpler &
> shorter the better, really.
>> We'd have to teach pgindent about that, and I dunno how hard that is.
> Maybe it is enough to just to turn "/* no-nl */" to "// no-nl" in
> pgindent's post_indent, but probably I'm too naïve:-)
Well, IMO the point of making that change would be to buy an additional
three characters of space for the comment before it wraps. So I'd suspect
that post-processing is too late. But I've not looked into pgindent to
see where the decisions are made exactly.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-10-25 00:37:24 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
Previous Message | Fabien COELHO | 2016-10-24 21:13:29 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2016-10-24 23:01:34 | Re: emergency outage requiring database restart |
Previous Message | Fabien COELHO | 2016-10-24 21:13:29 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |