From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> |
Cc: | "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Hackers" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: DROP TYPE/DROP DOMAIN |
Date: | 2003-08-05 13:56:10 |
Message-ID: | 21945.1060091770@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
"Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> Will DROP TYPE automatically handle dropping constraints and dependent
> columns properly?
Sure. Once you get down to the dependency-chaser, a type is a type.
> Will all its messages use the word 'domain' and not
> 'type'?
No, but I wouldn't bet on DROP DOMAIN uniformly saying "domain" either.
It's the same code as soon as you get below the top-level command
routine (compare RemoveType and RemoveDomain).
> I can't see any conceivable reason to allow this syntax to work!
> We are giving zero benefit for a non-zero cost...
I'd state that exactly the other way around: testing for and rejecting
domains in DROP TYPE will take more code (okay, only a few lines, but
still more code) and I consider the benefit nil.
If you try to make every message in the system distinguish "type" from
"domain", then you are talking about a *lot* more code, for even less
benefit. Also there are places where you simply can't know which to
say --- should "type not found" be changed to "domain not found"?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Dennis Björklund | 2003-08-05 14:13:11 | cvs branch to use? |
Previous Message | Shridhar Daithankar | 2003-08-05 13:48:34 | Re: 7.4 beta binaries |