From: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, giomac(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Re: [BUGS] BUG #7815: Upgrading PostgreSQL from 9.1 to 9.2 with pg_upgrade/postgreql-setup fails - invalid status retrieve |
Date: | 2013-08-12 20:08:07 |
Message-ID: | 2173089.HqHtjyoHSD@nb.usersys.redhat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
> The patch moves the atexit setting up, as you suggested, but only does
> that when pg_ctl succeeds (we know we started the server),
Yes, of course!
> PG 9.1+ will allow pg_ctl -w start to succeed even if there are
> permissions problems; earlier versions will not and will keep the
> server running --- the user will have to stop the server after
> pg_upgrade says it is running.
This makes it a complex, really.. We may not easily make the
stop_postmaster resistant to non-running server. Thus your solution must
be good enough.
> I am not going to backpatch this beyond 9.3 as it is risky code. I have
> improved the comments in this area.
Agree, it is OK for me — thanks for your work.
Pavel
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-08-12 20:29:10 | Re: [BUGS] BUG #8335: trim() un-document behaviour |
Previous Message | Bruce Momjian | 2013-08-12 19:33:47 | Re: [PATCH] Re: [BUGS] BUG #7815: Upgrading PostgreSQL from 9.1 to 9.2 with pg_upgrade/postgreql-setup fails - invalid status retrieve |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-08-12 20:29:10 | Re: [BUGS] BUG #8335: trim() un-document behaviour |
Previous Message | Bruce Momjian | 2013-08-12 19:33:47 | Re: [PATCH] Re: [BUGS] BUG #7815: Upgrading PostgreSQL from 9.1 to 9.2 with pg_upgrade/postgreql-setup fails - invalid status retrieve |