Re: pgsql-server/src/backend commands/typecmds.c e ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/backend commands/typecmds.c e ...
Date: 2003-09-10 06:09:50
Message-ID: 217.1063174190@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

petere(at)svr1(dot)postgresql(dot)org (Peter Eisentraut - PostgreSQL) writes:
> Modified files:
> src/backend/commands: typecmds.c
> src/backend/executor: execQual.c functions.c
> src/backend/parser: gram.y
> src/backend/tcop: utility.c
> src/backend/utils/adt: acl.c array_userfuncs.c pgstatfuncs.c
> ri_triggers.c ruleutils.c sets.c varbit.c
> src/backend/utils/fmgr: funcapi.c

> Log message:
> Some "feature not supported" errors are better syntax errors, because the
> feature they complain about isn't a feature or cannot be implemented without
> definitional changes.

I looked over this change, and right offhand I don't agree with any of
it. None of the errors are "syntax" errors (if they were, gram.y would
have barfed) and the textual error message changes generally seem to be
trending in a less not more helpful direction. What is your rationale
for this, please?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2003-09-10 06:24:57 Re: pgsql-server/src backend/bootstrap/Tag: backen ...
Previous Message Bruce Momjian 2003-09-10 03:56:35 pgsql-server/src Makefile.shlib