Re: BUG #13905: Inconsistent code modification

petrum(at)gmail(dot)com writes:
> Location: file src/include/catalog/pg_proc.h
> Lines 4613 and 4615 looks to be copies of lines 4252 and 4254,
> respectively.

It's generally better to show the actual lines you're talking about;
line numbers tend to not be all that stable. But I guess you are talking
about the DESCR lines for jsonb_to_record() and jsonb_to_recordset()?

> They are parts of a larger code fragment duplicated and modified by
> replacing *json* with *jsonb*. However, lines 4613 and 4615 are not modified
> accordingly i.e., they still contain the *json* sub-string and not the
> *jsonb* as it would be expected according to their neighbor source code
> lines.

Hmm, yeah. You could argue it either way perhaps as to whether these
comments should refer to JSON or the specific type name, but since all
the other jsonb functions do the latter, these should too.

Thanks for noticing!

regards, tom lane