Re: Solaris getopt_long and PostgreSQL

Perhaps I could use the same test pg_status uses to decide PS_USE_CHANGE_ARGV and PS_USE_CLOBBER_ARGV?

Any obviously, we don't just use ours for platforms with no or broken getopt_long, since we are talking Solaris (which has a bug in getopt, but getopt_long works fine)

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: Tuesday, March 17, 2009 11:26 AM
> To: Chuck McDevitt
> Cc: Zdenek Kotala; pgsql-hackers(at)postgresql(dot)org
> Subject: Re: [HACKERS] Solaris getopt_long and PostgreSQL
>
> Chuck McDevitt <cmcdevitt(at)greenplum(dot)com> writes:
> > This is because MAC, BSD and GNU getopt_long permutes the arguments,
> and our getopt_long does not.
>
> AFAIK those all work by scribbling on the original argv[] array, a
> behavior that seems pretty risky from a portability standpoint.
> Since our port/ module is only going to get used on old platforms with
> no or broken getopt_long(), it needs to be pretty conservative about
> what it assumes the system environment can handle.
>
> regards, tom lane