Re: Visual Studio 2005, C-language function - avoiding hacks?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: "Kevin Flanagan" <kevin-f(at)linkprior(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Visual Studio 2005, C-language function - avoiding hacks?
Date: 2010-03-08 06:15:55
Message-ID: 2106.1268028955@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> I'd like to propose to define PGALWAYSEXPORT macro:
> #ifdef WIN32
> #define PGALWAYSEXPORT __declspec (dllexport)
> #endif
> and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it
> instead of PGDLLEXPORT.

This seems like change for the sake of change. The existing mechanism
works (as demonstrated by the fact that the contrib modules work on
Windows). I don't think we should invent a new mechanism that won't be
backwards-compatible.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Takahiro Itagaki 2010-03-08 06:31:44 Re: Visual Studio 2005, C-language function - avoiding hacks?
Previous Message Takahiro Itagaki 2010-03-08 06:05:21 Re: Visual Studio 2005, C-language function - avoiding hacks?