Re: Writing WAL for relcache invalidation: pg_internal.init

"Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> Enclose a patch for new WAL records for relcache invalidation.

I don't think this works. RelationCacheInitFileInvalidate is executed
post-commit, which means that there's a window between commit and where
you propose to write the WAL entry. A crash and restart in that
interval would leave the catalog changes committed, but not reflected
into pg_internal.init.

I think we're probably better off to just forcibly remove the init file
during post-recovery cleanup. The easiest place to do this might be
BuildFlatFiles, which has to scan pg_database anyway ...

regards, tom lane