| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |
| Date: | 2010-04-24 00:00:03 |
| Message-ID: | 20305.1272067203@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Apr 23, 2010 at 7:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I would expect that they'll get an error message that makes it clear
>> enough what to do ;-). In any case, changing the name is hardly going
>> to fix things so that 8.4 settings will still work, so why are you
>> giving that case as an argument for it?
> Principle of obvious breakage.
And? If we do it by adding the new variable while not renaming
archive_mode, then I'd expect an 8.4 configuration to yield an error
along the lines of
ERROR: invalid combination of configuration parameters
HINT: To turn on archive_mode, you must set wal_mode to "archive" or "hot_standby".
(precise wording open to debate, but clearly we can do at least this
well) whereas if we rename archive_mode, it's unlikely we can do better
than
ERROR: unrecognized parameter "archive_mode"
Do you really think the second one is going to make any user happier
than the first?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-04-24 00:09:21 | Re: vcregress.bat check triggered Heap error in the Debug version of win32 build |
| Previous Message | Xiong He | 2010-04-23 23:38:54 | vcregress.bat check triggered Heap error in the Debug version of win32 build |